Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] Refactor web-socket heartbeat mechanism #4000

Closed
wants to merge 1 commit into from
Closed

[Draft] Refactor web-socket heartbeat mechanism #4000

wants to merge 1 commit into from

Conversation

atemate
Copy link
Contributor

@atemate atemate commented Aug 23, 2019

What do these changes do?

Are there changes in behavior for the user?

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@codecov-io
Copy link

codecov-io commented Aug 23, 2019

Codecov Report

Merging #4000 into master will decrease coverage by 3.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4000      +/-   ##
==========================================
- Coverage    97.8%   94.79%   -3.02%     
==========================================
  Files          43       43              
  Lines        8763     8764       +1     
  Branches     1375     1375              
==========================================
- Hits         8571     8308     -263     
- Misses         80      345     +265     
+ Partials      112      111       -1
Impacted Files Coverage Δ
aiohttp/http_websocket.py 98.63% <100%> (ø) ⬆️
aiohttp/worker.py 6.72% <0%> (-90.76%) ⬇️
aiohttp/resolver.py 45.61% <0%> (-54.39%) ⬇️
aiohttp/web_fileresponse.py 67.04% <0%> (-30.69%) ⬇️
aiohttp/tcp_helpers.py 66.66% <0%> (-26.67%) ⬇️
aiohttp/locks.py 92.85% <0%> (-7.15%) ⬇️
aiohttp/web_runner.py 92.47% <0%> (-5.31%) ⬇️
aiohttp/http_parser.py 92.39% <0%> (-4.7%) ⬇️
aiohttp/http_writer.py 95.28% <0%> (-3.78%) ⬇️
aiohttp/test_utils.py 97.7% <0%> (-1.97%) ⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 373f512...9ffa324. Read the comment docs.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Nov 22, 2019

This pull request introduces 1 alert when merging ccf2437 into 8691ca2 - view on LGTM.com

new alerts:

  • 1 for Wrong name for an argument in a call

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Dreamsorcerer
Copy link
Member

I suspect this has been superseded by @bdraco's work and appears abandoned anyway (there's no description or anything to even suggest the purpose).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants