Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPNotModified 304 must have no body #442

Closed
PolarNick239 opened this issue Jul 23, 2015 · 2 comments
Closed

HTTPNotModified 304 must have no body #442

PolarNick239 opened this issue Jul 23, 2015 · 2 comments
Labels
outdated

Comments

@PolarNick239
Copy link

In the following code:

response = web.HTTPNotModified(headers={'ETag': etag})

reponse will be constructed with body = b'304: Not Modified'
But empty body expected.

RFC:

... it responds with a special status code (usually, 304 (Not Modified)) and no entity-body ...

http://www.w3.org/Protocols/rfc2616/rfc2616-sec13.html#sec13.3

Workaround:

response = web.HTTPNotModified(headers={'ETag': etag}, body=b'')

For example QT client with small probability on such responses raises exception, that connection was closed. :(
@asvetlov
Copy link
Member

Fixed in by a0a9d32

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asvetlov @PolarNick239