[3.7] On exit, cancel the main task first (#3805) #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, some tasks might be cancelled before cleanup hooks run. Fixes #3593 (cherry picked from commit c32101d) Co-authored-by: multun <[email protected]>
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## 3.7 #4535 +/- ##
==========================================
- Coverage 97.92% 97.88% -0.04%
==========================================
Files 44 44
Lines 8953 8954 +1
Branches 1407 1407
==========================================
- Hits 8767 8765 -2
- Misses 79 81 +2
- Partials 107 108 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, some tasks might be cancelled before cleanup hooks run. Fixes #3593
(cherry picked from commit c32101d)
Co-authored-by: multun [email protected]