Added Python 3.5 “async for” compat to websocket

[flying-sheep]

Instead of

while True:
    msg = await ws.receive()
    ...
    elif msg.tp == web.MsgType.close:
        break

do:

async for msg in ws:
    ...

[flying-sheep]

uh, those test failures are no my fault. i fixed them in #544

[flying-sheep]

triggering rebuild

[flying-sheep]

hmm, OK, now the error is:

$ flake8 aiohttp
aiohttp/web_ws.py:297:19: F821 undefined name 'StopAsyncIteration'

but this is wrong. of course this is an undefined name in python < 3.5, but as you’d have to call ws.__anext__() manually in those versions, and you don’t do that because it’s a magic method wrapping receive.

so i’ll just make flake8 shut up.

[asvetlov]

Tests and documentation update are required

[flying-sheep]

i don’t seem to get this test to run. it hangs, don’t know why…

[carlcarl]

In Travis log: aiohttp/web_ws.py:295:1: W293 blank line contains whitespace.
There are spaces at line 295.
(The testing use flake8 to check the coding style at the beginning)

[flying-sheep]

i know, i just made a last-minute fix and didn’t run it after 😐

check the new one, that’s the real problem.

[carlcarl]

Seems hangs on test_web_websocket.py line 42:

msg = await resp._reader.read()

In resp._reader.read(), check streams.py line 374:

yield from self._waiter

It stops there I guess...

[flying-sheep]

ya. why?

[carlcarl]

Here is the part of the my testing in test_await:

    items = ['q1', 'q2', 'q3']
    for item in items:
        resp._writer.send(item)
        msg = await resp._reader.read()
        assert msg.tp == websocket.MSG_TEXT
        assert item + '/answer' == msg.data

    resp._writer.close()

    msg = await resp._reader.read()
    assert msg.tp == websocket.MSG_CLOSE
    assert msg.data == 1000
    assert msg.extra == ''

    await closed
    await resp.close()

Server will not know if it need to send close message back. So you need to send close first or it will wait for receive forever.

Also, remember to await resp.close()

[flying-sheep]

thanks! you saved me quite some time. 🙇

i copied the test from elsewhere and adapted it … poorly.

i hope this is it then!

[asvetlov]

Why do you need private attribute access. The test may use send() and receive() client response methods.

[flying-sheep]

eh, no idea, i copied stuff from elsewhere. what methods are you referring to?

[carlcarl]

resp._writer.send(item) ?
I think he means _writer is a private attribute and should not be used in testing.

[flying-sheep]

sure. my question is what i should use instead

[asvetlov]

http://aiohttp.readthedocs.org/en/stable/client_websockets.html

[flying-sheep]

oh, sorry. i would have done it eventually 😅

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.