Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename a shadowed test and re-enable F811 to catch future cases #8139

Merged
merged 6 commits into from
Feb 8, 2024
Merged

rename a shadowed test and re-enable F811 to catch future cases #8139

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3b020d0
rename an inadvertently shadowed test and re-enable F811 to catch fut…
alexmac Feb 7, 2024
1a03c73
add file to CHANGES
alexmac Feb 7, 2024
6e68cfe
PR feedback
alexmac Feb 7, 2024
4fefdc3
Update tests/test_urldispatch.py
Dreamsorcerer Feb 7, 2024
a735528
Merge branch 'master' into alex/duplicate-test
Dreamsorcerer Feb 8, 2024
42e404c
Merge branch 'master' into alex/duplicate-test
Dreamsorcerer Feb 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGES/8139.contrib.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Two definitions for "test_invalid_route_name" existed, only one was being run. Refactored them into a single parameterized test. Enabled lint rule to prevent regression. -- by :user:`alexmac`.
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ zip_ok = false
[flake8]
extend-select = B950
# TODO: don't disable D*, fix up issues instead
ignore = N801,N802,N803,E203,E226,E305,W504,E252,E301,E302,E501,E704,W503,W504,F811,D1,D4
Dreamsorcerer marked this conversation as resolved.
Show resolved Hide resolved
ignore = N801,N802,N803,E203,E226,E305,W504,E252,E301,E302,E501,E704,W503,W504,D1,D4
max-line-length = 88
per-file-ignores =
# I900: Shouldn't appear in requirements for examples.
Expand Down
16 changes: 9 additions & 7 deletions tests/test_urldispatch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,14 +1146,16 @@ def test_subapp_iter(app: Any) -> None:
assert list(resource) == [r1, r2]


def test_invalid_route_name(router: Any) -> None:
with pytest.raises(ValueError):
router.add_get("/", make_handler(), name="invalid name")


def test_invalid_route_name(router) -> None:
@pytest.mark.parametrize(
"route_name",
[
"invalid name",
"class",
],
Dreamsorcerer marked this conversation as resolved.
Show resolved Hide resolved
)
def test_invalid_route_name(router: Any, route_name: str) -> None:
with pytest.raises(ValueError):
router.add_get("/", make_handler(), name="class") # identifier
router.add_get("/", make_handler(), name=route_name)


def test_frozen_router(router: Any) -> None:
Expand Down