Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8163/006fbe03 backport][3.9] Avoid creating a task to do DNS resolution if there is no throttle #8172

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Feb 20, 2024

This is a backport of PR #8163 as merged into master (006fbe0).

What do these changes do?

Avoid creating a task to do dns resolution if there is no throttle

When doing some debugging, I noticed that a large amount of tasks created on a Home Assistant instance were TCPConnector._resolve_host for cases where the host was an ip address or already in the cache. On this instance, it reduced the number of _resolve_host tasks by 99%. Previously I observed ~500 per minute.

Are there changes in behavior for the user?

There is a small performance improvement on cache hit and when the host is an ip address. Since requests no longer have to suspend on cache hit this can reduce latency of requests. Scheduling and awaiting a task on the event loop can take 2 order of magnitude more wall clock time vs running a simple function.

Is it a substantial burden for the maintainers to support this?

no

Related issue number

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

…8163)

Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <[email protected]>
(cherry picked from commit 006fbe0)
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (87e0697) 97.30% compared to head (5eab05d) 97.36%.

Additional details and impacted files
@@            Coverage Diff             @@
##              3.9    #8172      +/-   ##
==========================================
+ Coverage   97.30%   97.36%   +0.06%     
==========================================
  Files         108      108              
  Lines       32628    32637       +9     
  Branches     3875     3874       -1     
==========================================
+ Hits        31748    31778      +30     
+ Misses        672      655      -17     
+ Partials      208      204       -4     
Flag Coverage Δ
CI-GHA 97.27% <100.00%> (+0.05%) ⬆️
OS-Linux 96.96% <100.00%> (+0.06%) ⬆️
OS-Windows 94.48% <100.00%> (+0.11%) ⬆️
OS-macOS 96.78% <100.00%> (+0.42%) ⬆️
Py-3.10.11 94.38% <100.00%> (?)
Py-3.10.13 96.75% <100.00%> (+0.03%) ⬆️
Py-3.11.7 96.36% <100.00%> (-0.01%) ⬇️
Py-3.11.8 96.47% <100.00%> (-0.01%) ⬇️
Py-3.12.2 96.52% <100.00%> (?)
Py-3.8.10 94.35% <100.00%> (?)
Py-3.8.18 96.68% <100.00%> (-0.01%) ⬇️
Py-3.9.13 94.37% <100.00%> (+<0.01%) ⬆️
Py-3.9.18 96.72% <100.00%> (+0.02%) ⬆️
Py-pypy7.3.15 96.27% <100.00%> (?)
VM-macos 96.78% <100.00%> (+0.42%) ⬆️
VM-ubuntu 96.96% <100.00%> (+0.06%) ⬆️
VM-windows 94.48% <100.00%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit e74a4a0 into 3.9 Feb 20, 2024
28 of 31 checks passed
@bdraco bdraco deleted the patchback/backports/3.9/006fbe03fede4eaa1eeba7b8393cbf4d63cb44b6/pr-8163 branch February 20, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant