Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #8681/30a3d0ef backport][3.10] Improve performance of starting request handlers with Python 3.12+ #8725

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Aug 17, 2024

This is a backport of PR #8681 as merged into master (30a3d0e).

What do these changes do?

Improve performance of starting request handlers with Python 3.12+ by starting the task eagerly.

followup to #8661 as I missed one more place we create a task

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

Copy link

codecov bot commented Aug 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.69%. Comparing base (78d45e7) to head (8164e70).
Report is 5 commits behind head on 3.10.

Additional details and impacted files
@@            Coverage Diff             @@
##             3.10    #8725      +/-   ##
==========================================
+ Coverage   96.71%   97.69%   +0.97%     
==========================================
  Files         106      108       +2     
  Lines       34018    34092      +74     
  Branches     3264     4058     +794     
==========================================
+ Hits        32901    33305     +404     
+ Misses        854      587     -267     
+ Partials      263      200      -63     
Flag Coverage Δ
CI-GHA 97.58% <83.33%> (+0.86%) ⬆️
OS-Linux 97.26% <83.33%> (?)
OS-Windows 94.79% <83.33%> (?)
OS-macOS 96.92% <83.33%> (+0.21%) ⬆️
Py-3.10.11 97.02% <66.66%> (+0.30%) ⬆️
Py-3.10.14 96.97% <66.66%> (?)
Py-3.11.9 97.20% <66.66%> (?)
Py-3.12.4 97.30% <66.66%> (?)
Py-3.8.10 94.40% <66.66%> (?)
Py-3.8.18 96.75% <66.66%> (?)
Py-3.9.13 96.90% <66.66%> (?)
Py-3.9.19 96.85% <66.66%> (?)
Py-pypy7.3.16 96.45% <66.66%> (?)
VM-macos 96.92% <83.33%> (+0.21%) ⬆️
VM-ubuntu 97.26% <83.33%> (?)
VM-windows 94.79% <83.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit ebec945 into 3.10 Aug 17, 2024
30 of 31 checks passed
@bdraco bdraco deleted the patchback/backports/3.10/30a3d0ef1ddfec7351d7dc322e738be14c29759a/pr-8681 branch August 17, 2024 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant