Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix resource reuse with regex paths #8998

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Fix resource reuse with regex paths #8998

merged 2 commits into from
Sep 4, 2024

Conversation

Dreamsorcerer
Copy link
Member

@Dreamsorcerer Dreamsorcerer commented Sep 3, 2024 •
edited
Loading

Fixes #7624.

@Dreamsorcerer Dreamsorcerer added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 3, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 3, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.29%. Comparing base (5c3d50f) to head (e29905f).
Report is 10 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8998   +/-   ##
=======================================
  Coverage   98.28%   98.29%           
=======================================
  Files         107      107           
  Lines       34317    34339   +22     
  Branches     4064     4066    +2     
=======================================
+ Hits        33729    33753   +24     
+ Misses        415      414    -1     
+ Partials      173      172    -1
Flag Coverage Δ
CI-GHA 98.18% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.85% <100.00%> (+<0.01%) ⬆️
OS-Windows 96.26% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.52% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.62% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.55% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.78% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.90% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.51% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 97.45% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 97.06% <100.00%> (+<0.01%) ⬆️
VM-macos 97.52% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.85% <100.00%> (+<0.01%) ⬆️
VM-windows 96.26% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer Dreamsorcerer merged commit 875f23d into master Sep 4, 2024
35 of 36 checks passed
@Dreamsorcerer Dreamsorcerer deleted the fix-reuse-paths-regex branch September 4, 2024 12:26
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 4, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/875f23d516220a1cf849eb4a6d758edb8bff1f55/pr-8998

Backported as #9016

🤖 @patchback
I'm built with octomachinery and
my source is open — https:/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 4, 2024
@Dreamsorcerer @patchback
Fix resource reuse with regex paths (#8998)
fe82a5e 
(cherry picked from commit 875f23d)
@patchback patchback bot mentioned this pull request Sep 4, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 4, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/875f23d516220a1cf849eb4a6d758edb8bff1f55/pr-8998

Backported as #9017

🤖 @patchback
I'm built with octomachinery and
my source is open — https:/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 4, 2024
@Dreamsorcerer @patchback
Fix resource reuse with regex paths (#8998)
46390b0 
(cherry picked from commit 875f23d)
@patchback patchback bot mentioned this pull request Sep 4, 2024
Merged
Dreamsorcerer added a commit that referenced this pull request Sep 4, 2024
@patchback @Dreamsorcerer
[PR #8998/875f23d5 backport][3.11] Fix resource reuse with regex paths (
37ca369 
#9017)

**This is a backport of PR #8998 as merged into master
(875f23d).**

Co-authored-by: Sam Bull <[email protected]>
Dreamsorcerer added a commit that referenced this pull request Sep 4, 2024
@patchback @Dreamsorcerer
[PR #8998/875f23d5 backport][3.10] Fix resource reuse with regex paths (
f5bf86a 
#9016)

**This is a backport of PR #8998 as merged into master
(875f23d).**

Co-authored-by: Sam Bull <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdraco bdraco bdraco approved these changes

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource reuse not working for dynamic resources
2 participants
@Dreamsorcerer @bdraco