Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid tracing overhead in http_writer when there are no traces #9031

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Avoid tracing overhead in http_writer when there are no traces #9031

merged 2 commits into from
Sep 6, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 5, 2024 •
edited
Loading

What do these changes do?

If there are not traces set for the request, we would still create partial functions in ClientRequest and call them in http_writer

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

before
write_headers_before

after
write_headers_after

@bdraco
Avoid tracing overhead in http_writer when there are no traces
9bfa1fe 
If there are not traces set for the request, we would still
create partial functions in ClientRequest and call them in http_writer
@codecov Codecov
Copy link

codecov bot commented Sep 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (e8d8e28) to head (8c7d298).
Report is 4 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9031   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         107      107           
  Lines       34355    34355           
  Branches     4066     4066           
=======================================
  Hits        33771    33771           
  Misses        412      412           
  Partials      172      172
Flag Coverage Δ
CI-GHA 98.19% <ø> (ø)
OS-Linux 97.85% <ø> (ø)
OS-Windows 96.26% <ø> (ø)
OS-macOS 97.53% <ø> (ø)
Py-3.10.11 97.63% <ø> (ø)
Py-3.10.14 97.56% <ø> (ø)
Py-3.11.9 97.79% <ø> (ø)
Py-3.12.5 97.91% <ø> (ø)
Py-3.9.13 97.51% <ø> (ø)
Py-3.9.19 97.46% <ø> (ø)
Py-pypy7.3.16 97.07% <ø> (ø)
VM-macos 97.53% <ø> (ø)
VM-ubuntu 97.85% <ø> (ø)
VM-windows 96.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 5, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 6, 2024
@bdraco bdraco marked this pull request as ready for review September 6, 2024 19:20
@bdraco bdraco enabled auto-merge (squash) September 6, 2024 19:20
@bdraco bdraco merged commit 9f0ae07 into master Sep 6, 2024
33 of 34 checks passed
@bdraco bdraco deleted the tracing_overhead branch September 6, 2024 19:28
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 6, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/9f0ae07459844d51a017fd0cfa4d0ca6092d1ee1/pr-9031

Backported as #9045

🤖 @patchback
I'm built with octomachinery and
my source is open — https:/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 6, 2024
@bdraco @patchback
Avoid tracing overhead in http_writer when there are no traces (#9031)
0eb6783 
(cherry picked from commit 9f0ae07)
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 6, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/9f0ae07459844d51a017fd0cfa4d0ca6092d1ee1/pr-9031

Backported as #9046

🤖 @patchback
I'm built with octomachinery and
my source is open — https:/sanitizers/patchback-github-app.

@patchback patchback bot mentioned this pull request Sep 6, 2024
Merged
patchback bot pushed a commit that referenced this pull request Sep 6, 2024
@bdraco @patchback
Avoid tracing overhead in http_writer when there are no traces (#9031)
a1785d2 
(cherry picked from commit 9f0ae07)
@patchback patchback bot mentioned this pull request Sep 6, 2024
Merged
bdraco added a commit that referenced this pull request Sep 6, 2024
@patchback @bdraco
[PR #9031/9f0ae074 backport][3.10] Avoid tracing overhead in http_wri…
9c34a8c 
…ter when there are no traces (#9045)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Sep 6, 2024
@patchback @bdraco
[PR #9031/9f0ae074 backport][3.11] Avoid tracing overhead in http_wri…
8f30c91 
…ter when there are no traces (#9046)

Co-authored-by: J. Nick Koston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dreamsorcerer Dreamsorcerer Dreamsorcerer approved these changes

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bdraco @Dreamsorcerer