Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync reify Cython implementation with yarl #9054

Merged
merged 2 commits into from
Sep 7, 2024
Merged

Sync reify Cython implementation with yarl #9054

merged 2 commits into from
Sep 7, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 7, 2024

The version in yarl was optimized to be slightly faster, sync it here. The goal it to eventually move this into an external library to avoid code duplication.

Are there changes in behavior for the user?

no

Is it a substantial burden for the maintainers to support this?

no

@bdraco
Sync reify Cython implementation with yarl
7f59fcc 
The version in yarl was optimized to be slightly faster,
sync it here. The goal it to eventually move this into
an external library to avoid code duplication.
@bdraco bdraco added backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot labels Sep 7, 2024
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 7, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.30%. Comparing base (684b792) to head (4bb9cc3).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #9054   +/-   ##
=======================================
  Coverage   98.30%   98.30%           
=======================================
  Files         107      107           
  Lines       34356    34356           
  Branches     4071     4071           
=======================================
  Hits        33772    33772           
  Misses        412      412           
  Partials      172      172
Flag Coverage Δ
CI-GHA 98.19% <ø> (ø)
OS-Linux 97.85% <ø> (ø)
OS-Windows 96.26% <ø> (ø)
OS-macOS 97.53% <ø> (+<0.01%) ⬆️
Py-3.10.11 97.63% <ø> (ø)
Py-3.10.14 97.56% <ø> (ø)
Py-3.11.9 97.79% <ø> (ø)
Py-3.12.5 97.91% <ø> (ø)
Py-3.9.13 97.51% <ø> (ø)
Py-3.9.19 97.46% <ø> (ø)
Py-pypy7.3.16 97.06% <ø> (-0.01%) ⬇️
VM-macos 97.53% <ø> (+<0.01%) ⬆️
VM-ubuntu 97.85% <ø> (ø)
VM-windows 96.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco marked this pull request as ready for review September 7, 2024 20:52
@bdraco bdraco merged commit c3da10c into master Sep 7, 2024
35 of 36 checks passed
@bdraco bdraco deleted the sync_reify_yarl branch September 7, 2024 20:52
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 7, 2024 •
edited
Loading

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/c3da10cdd6e947427249900826b9ff653991b19e/pr-9054

Backported as #9057

🤖 @patchback
I'm built with octomachinery and
my source is open — https:/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 7, 2024
@bdraco @patchback
Sync reify Cython implementation with yarl (#9054)
dcea899 
(cherry picked from commit c3da10c)
@patchback patchback bot mentioned this pull request Sep 7, 2024
Merged
@patchback Patchback
Copy link
Contributor

patchback bot commented Sep 7, 2024 •
edited
Loading

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/c3da10cdd6e947427249900826b9ff653991b19e/pr-9054

Backported as #9058

🤖 @patchback
I'm built with octomachinery and
my source is open — https:/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Sep 7, 2024
@bdraco @patchback
Sync reify Cython implementation with yarl (#9054)
58d2d94 
(cherry picked from commit c3da10c)
@patchback patchback bot mentioned this pull request Sep 7, 2024
Merged
bdraco added a commit that referenced this pull request Sep 7, 2024
@patchback @bdraco
[PR #9054/c3da10cd backport][3.10] Sync reify Cython implementation w…
f631015 
…ith yarl (#9057)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Sep 7, 2024
@patchback @bdraco
[PR #9054/c3da10cd backport][3.11] Sync reify Cython implementation w…
2f30ac4 
…ith yarl (#9058)

Co-authored-by: J. Nick Koston <[email protected]>
bdraco added a commit that referenced this pull request Sep 18, 2024
@bdraco
Revert "[PR #9054/c3da10cd backport][3.10] Sync reify Cython implemen…
09498bd 
…tation with yarl (#9057)"

This reverts commit f631015.
bdraco added a commit that referenced this pull request Sep 18, 2024
@bdraco
Revert "Revert "[PR #9054/c3da10cd backport][3.10] Sync reify Cython …
fb98dec 
…implementation with yarl (#9057)""

This reverts commit 09498bd.
bdraco added a commit that referenced this pull request Sep 18, 2024
@bdraco
Revert "Revert "Revert "[PR #9054/c3da10cd backport][3.10] Sync reify…
bb8019b 
… Cython implementation with yarl (#9057)"""

This reverts commit fb98dec.
bdraco added a commit that referenced this pull request Sep 18, 2024
@bdraco
Revert "Revert "Revert "Revert "[PR #9054/c3da10cd backport][3.10] Sy…
8dc1a2a 
…nc reify Cython implementation with yarl (#9057)""""

This reverts commit bb8019b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner

@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Assignees
No one assigned
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bdraco