Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #9068/841d00e backport][3.11] Use URL.extend_query to add params in ClientRequest #9078

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Sep 9, 2024

(cherry picked from commit 841d00e)

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Sep 9, 2024
@bdraco bdraco changed the title Use URL.extend_query to add params in ClientRequest (#9068) [PR #9068/841d00e backport][3.11] Use URL.extend_query to add params in ClientRequest Sep 9, 2024
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (3794391) to head (2b51517).
Report is 2 commits behind head on 3.11.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             3.11    #9078   +/-   ##
=======================================
  Coverage   97.76%   97.76%           
=======================================
  Files         108      108           
  Lines       34536    34543    +7     
  Branches     4098     4104    +6     
=======================================
+ Hits        33765    33772    +7     
  Misses        576      576           
  Partials      195      195           
Flag Coverage Δ
CI-GHA 97.66% <100.00%> (+<0.01%) ⬆️
OS-Linux 97.35% <100.00%> (+<0.01%) ⬆️
OS-Windows 94.91% <100.00%> (+<0.01%) ⬆️
OS-macOS 97.04% <100.00%> (+<0.01%) ⬆️
Py-3.10.11 97.12% <100.00%> (+<0.01%) ⬆️
Py-3.10.14 97.06% <100.00%> (+<0.01%) ⬆️
Py-3.11.9 97.28% <100.00%> (+<0.01%) ⬆️
Py-3.12.5 97.39% <100.00%> (+<0.01%) ⬆️
Py-3.9.13 97.02% <100.00%> (+<0.01%) ⬆️
Py-3.9.19 96.96% <100.00%> (+<0.01%) ⬆️
Py-pypy7.3.16 96.56% <100.00%> (+<0.01%) ⬆️
VM-macos 97.04% <100.00%> (+<0.01%) ⬆️
VM-ubuntu 97.35% <100.00%> (+<0.01%) ⬆️
VM-windows 94.91% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit 7fd5e73 into 3.11 Sep 9, 2024
30 of 31 checks passed
@bdraco bdraco deleted the patchback/backports/3.11/841d00eb3c5393fc6eccbfcd09114b14c74772d4/pr-9068 branch September 9, 2024 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant