Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of splitting the netloc on cache miss #1338

Closed
wants to merge 1 commit into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 19, 2024

No description provided.

yarl/_url.py Show resolved Hide resolved
Copy link

codspeed-hq bot commented Oct 19, 2024

CodSpeed Performance Report

Merging #1338 will not alter performance

Comparing raw_host (f379998) with master (7cdbf04)

Summary

✅ 81 untouched benchmarks

Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.06%. Comparing base (7cdbf04) to head (f379998).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1338      +/-   ##
==========================================
+ Coverage   95.99%   96.06%   +0.06%     
==========================================
  Files          27       27              
  Lines        5441     5434       -7     
  Branches      336      336              
==========================================
- Hits         5223     5220       -3     
+ Misses        192      188       -4     
  Partials       26       26              
Flag Coverage Δ
CI-GHA 96.06% <100.00%> (+0.06%) ⬆️
MyPy 44.43% <77.77%> (+0.07%) ⬆️
OS-Linux 99.21% <100.00%> (-0.01%) ⬇️
OS-Windows 99.26% <100.00%> (-0.01%) ⬇️
OS-macOS 98.94% <100.00%> (-0.01%) ⬇️
Py-3.10.11 98.92% <100.00%> (-0.01%) ⬇️
Py-3.10.15 99.17% <100.00%> (-0.01%) ⬇️
Py-3.11.10 99.17% <100.00%> (-0.01%) ⬇️
Py-3.11.9 98.92% <100.00%> (-0.01%) ⬇️
Py-3.12.7 99.17% <100.00%> (-0.01%) ⬇️
Py-3.13.0 99.17% <100.00%> (-0.01%) ⬇️
Py-3.9.13 98.87% <100.00%> (-0.01%) ⬇️
Py-3.9.20 99.12% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.16 99.16% <100.00%> (-0.01%) ⬇️
Py-pypy7.3.17 99.19% <100.00%> (-0.01%) ⬇️
VM-macos-latest 98.94% <100.00%> (-0.01%) ⬇️
VM-ubuntu-latest 99.21% <100.00%> (-0.01%) ⬇️
VM-windows-latest 99.26% <100.00%> (-0.01%) ⬇️
pytest 99.21% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco closed this Oct 19, 2024
@bdraco
Copy link
Member Author

bdraco commented Oct 19, 2024

Doesn't look to be worth it anyways

@bdraco bdraco deleted the raw_host branch October 19, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant