Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the project version to 1.9.2 #858

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Bump the project version to 1.9.2 #858

merged 1 commit into from
Apr 25, 2023

Conversation

mjpieters
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Merging #858 (288812d) into master (475ee4a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #858   +/-   ##
=======================================
  Coverage   99.74%   99.74%           
=======================================
  Files           4        4           
  Lines         772      772           
  Branches      219      219           
=======================================
  Hits          770      770           
  Misses          2        2           
Flag Coverage Δ
unit 99.61% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
yarl/__init__.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mjpieters mjpieters merged commit 288812d into master Apr 25, 2023
@mjpieters mjpieters deleted the release_1_9_2 branch April 25, 2023 15:56
@mjpieters mjpieters temporarily deployed to release April 25, 2023 17:23 — with GitHub Actions Inactive
@@ -14,6 +14,15 @@ Changelog

.. towncrier release notes start

1.8.2 (2023-04-25)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjpieters this is why the release failed

Copy link
Contributor Author

@mjpieters mjpieters Apr 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, automation fails again. So towncrier looks at the git tags, not the version in __init__.py, and my local checkout did not yet have all the tags present.

We should either fix towncrier to run git fetch --tags first, and / or check for this particular error before starting the 80 minute whee building steps. :-D

Even better, put the check into a pre-commit hook..

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correction: it's not from the tags, it is from the project version, but somehow my virtualenv had two yarl versions; 1.8.2 and the editable install with the correct 1.9.2 version. 🤦

webknjaz added a commit that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants