feat(AIP-136): require GET/POST, use parent instead of singular #1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The resource singular is a harder pattern to recognize as it requires a consumer to know the resource singular beforehand. Using parent aligns it with other collection-oriented methods. Further explanation for the rationale is in the changes for AIP-136. fixes aip-dev#1089
|
@bgrant0607 FYI here's the fix for custom methods. |
noahdietz
reviewed
May 9, 2023
bgrant0607
reviewed
May 9, 2023
- creating a resource-oriented section to put resource-specific guidance. - making should a must to clarify level of strictness. - clarifying some wording, more succincet explanations.
|
Thanks @noahdietz @bgrant0607! Great comments, addressed. PTAL. |
noahdietz
reviewed
May 9, 2023
noahdietz
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The resource singular is a harder pattern to recognize as it
requires a consumer to know the resource singular beforehand. Using
parent aligns it with other collection-oriented methods.
Further explanation for the rationale is in the changes for AIP-136.
fixes #1089