Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List common packages that are org-specific or non-conformant #1157

Merged
merged 4 commits into from
Jul 5, 2023
Merged

List common packages that are org-specific or non-conformant #1157

merged 4 commits into from
Jul 5, 2023

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Jun 28, 2023

Fixes #1142

cc @bshaffer who requested this.

@jskeet jskeet requested a review from toumorokoshi June 28, 2023 16:49
@jskeet jskeet requested a review from a team as a code owner June 28, 2023 16:49
@jskeet jskeet requested a review from bgrant0607 June 28, 2023 16:49
toumorokoshi
toumorokoshi approved these changes Jun 29, 2023
View reviewed changes
Copy link
Contributor

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! good change to add.

aip/general/0213.md Show resolved Hide resolved
@jskeet jskeet merged commit bc5a961 into aip-dev:master Jul 5, 2023
2 checks passed
@jskeet jskeet deleted the org-common branch July 5, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bshaffer bshaffer bshaffer left review comments

@toumorokoshi toumorokoshi toumorokoshi approved these changes

@noahdietz noahdietz noahdietz approved these changes

@bgrant0607 bgrant0607 Awaiting requested review from bgrant0607 bgrant0607 is a code owner automatically assigned from aip-dev/google

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AIP-213: add a section for existing org-specific common protos
4 participants
@jskeet @bshaffer @toumorokoshi @noahdietz