Fix color output on Windows #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A question for this code: |
|
@8LWXpg yes, the related code need to refactor 😄 |
makiuchi-d
reviewed
Sep 22, 2024
Comment on lines
+34
to
+35
| c.Stdout = os.Stdout | ||
| c.Stderr = os.Stderr |
There was a problem hiding this comment.
These are overwrite StdoutPipe and StderrPipe.
https://cs.opensource.google/go/go/+/refs/tags/go1.23.1:src/os/exec/exec.go;l=1067
These pipe calls above should be removed.
jesses-code-adventures
pushed a commit
to jesses-code-adventures/air
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #128
I simply compare
util_windows.gowithutil_unix.go, and settingc.Stdout,c.Stderrseems to have resolve this issue.Screenshot