Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose ShowkaseBrowserComponent (and color and typography) in PaparazziShowkaseTestPreview #320

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

andersu
Copy link

@andersu andersu commented Apr 20, 2023

Expanding on #294 by @vinaygaba I wanted more control of when the screenshot should actually be taken.

My use case is that I want some screenshots to be taken for every locale that we support in our app. In these kind of previews we typically use localised string resources.
For other screenshots we just use dummy texts in English and only want one screenshot taken.

I have added one localised button preview where the text is "Button" in English and "Knapp" in Norwegian and I use my new callback in the sample module.

Let me know if you can think of other better ways to achieve what I want.

I notice that a lot of screenshots changed when I ran
./gradlew :showkase-screenshot-testing-paparazzi-sample:recordPaparazziDebug
Let me know if you think I messed something up.

@andersu andersu closed this Apr 28, 2023
@andersu andersu reopened this Apr 28, 2023
@andersu andersu changed the title Add callback to control if screenshot should be taken Expose ShowkaseBrowserComponent (and color and typography) in PaparazziShowkaseTestPreview May 9, 2023
@andersu
Copy link
Author

andersu commented May 19, 2023

@vinaygaba I can't see any details of why the ui-testing workflows fail. Are there any commands I can run locally to try to figure it out?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants