rails/http: monkey-patch with prepend instead of method chaining #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 12, 2021
Fixes #1161 (missing prepend instrumentation leads to stack level too deep error) Since we don't care about Ruby 1.9 support, we can safely rely on `prepend` to monkey-patch methods safely. This is more robust because nobody will overwrite our implementation (unless they forget to call `super`) and we will also respect other libraries that monkey-patch `HTTP::Client#perform`.
kyrylo
force-pushed
the
1161-http-client-prepend
branch
from
9db8361
to
4ac2ecd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1161 (missing prepend instrumentation leads to stack level too deep
error)
Since we don't care about Ruby 1.9 support, we can safely rely on
prependtomonkey-patch methods safely. This is more robust because nobody will overwrite
our implementation (unless they forget to call
super) and we will also respectother libraries that monkey-patch
HTTP::Client#perform.