Fix keyword argument error in Sneakers integration #1065
Conversation
The Sneakers::ErrorReporter worker_error method context_hash parameter is Hash data, not keyword parameters. Declare our handler accordingly.
BrianHawley
force-pushed
the
fixes_sneakers_keyword_error
branch
from
70fd1f3
to
2a86850
Compare
|
This fixes Ruby 2.7 keyword argument errors. |
| def call(exception, worker = nil, **context) | ||
| # rubocop:disable Style/OptionalArguments | ||
| def call(exception, worker = nil, context) | ||
| # Later versions add a middle argument. |
There was a problem hiding this comment.
Could you elaborate on this? I'm not a Sneakers user myself and this integration was contributed by someone else.
I can see that Sneakers actually always passes 2nd argument:
https:/jondot/sneakers/blob/7c059d1490e4dde43f98b801c38e4e0df7ac458c/lib/sneakers/error_reporter.rb#L18
Perhaps, we should just delete = nil so that the signature is:
def call(exception, worker, context)
There was a problem hiding this comment.
That won't work with some versions of Sneakers. I'm not a Sneakers user myself but I tracked down the code that calls this handler and reviewed its commit history.
At one point they added a second argument in the middle, which they always pass in versions since then. For versions before then they only pass two arguments, which for this handler correspond to the first and last argument; for those versions, we would get nil for the middle argument if we make it optional here.
Good thing we don't actually use the middle argument in this handler.
The Sneakers::ErrorReporter worker_error method context_hash parameter
is Hash data, not keyword parameters. Declare our handler accordingly.