Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isort only if imports at the top of the module were edited (Sourcery refactored) #277

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/darker/__main__.py
Original file line number Diff line number Diff line change
Expand Up @@ -360,8 +360,7 @@ def main(argv: List[str] = None) -> int:
" Either --diff or --check must be used.",
)

missing = get_missing_at_revision(paths, revrange.rev2, root)
if missing:
if missing := get_missing_at_revision(paths, revrange.rev2, root):
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function main refactored with the following changes:

missing_reprs = " ".join(repr(str(path)) for path in missing)
rev2_repr = "the working tree" if revrange.rev2 == WORKTREE else revrange.rev2
raise ArgumentError(
Expand Down
4 changes: 2 additions & 2 deletions src/darker/tests/test_main.py
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ def test_format_edited_parts_all_unchanged(git_repo, monkeypatch):
)
)

assert result == []
assert not result
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function test_format_edited_parts_all_unchanged refactored with the following changes:



def test_format_edited_parts_ast_changed(git_repo, caplog):
Expand Down Expand Up @@ -276,7 +276,7 @@ def test_format_edited_parts_isort_on_already_formatted(git_repo):
report_unmodified=False,
)

assert list(result) == []
assert not list(result)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function test_format_edited_parts_isort_on_already_formatted refactored with the following changes:



@pytest.mark.kwparametrize(
Expand Down