Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to support Spring boot 3 #280

Merged
merged 2 commits into from
Apr 23, 2023

Conversation

Pirayya
Copy link

@Pirayya Pirayya commented Dec 20, 2022

Describe the changes

  • Upgrade Spring boot to version 3.0.0
  • Changed Joran Actions to the new way of handling Actions, looked at the implementation Pivotal made in Spring org.springframework.boot.logging.logback.Spring*
  • Bumped version to 4.0.0-SNAPSHOT

Closes #279

@@ -37,6 +41,10 @@ class LogbackAccessEvent(private var source: LogbackAccessEventSource) : IAccess
return source.timeStamp
}

override fun getSequenceNumber(): Long {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is necessary

Copy link
Owner

@akkinoc akkinoc May 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like a new feature has been added in Logback v1.3.
https://logback.qos.ch/manual/configuration.html#sequenceNumberGenerator

<configuration>
    <sequenceNumberGenerator class="ch.qos.logback.core.spi.BasicSequenceNumberGenerator"/>

     <!-- rest of the configuration file .... -->
</configuration>

I have made corrections here:

- Followed new way of handling Actions, looked at the implementation Pivotal made in Spring.
@Pirayya Pirayya force-pushed the upgrade-to-support-spring-boot-3 branch from b0190c5 to bdbc2d9 Compare December 20, 2022 15:18
@akkinoc akkinoc self-assigned this Dec 28, 2022
@akkinoc akkinoc added this to the v4 milestone Dec 28, 2022
@akkinoc akkinoc assigned Pirayya and akkinoc and unassigned akkinoc Dec 28, 2022
@akkinoc akkinoc added the type:enhancement An enhancement or improvement. label Dec 28, 2022
@akkinoc
Copy link
Owner

akkinoc commented Dec 28, 2022

Thanks for contributing!
Please give me some time to think about it.

@Pirayya
Copy link
Author

Pirayya commented Jan 5, 2023

Thanks for contributing! Please give me some time to think about it.

Please feel free to change or copy the code however you want, I don't really care about contribution status, I just want to be able to use this library with Spring Boot 3 😄

@istvan-derda
Copy link

Hi @akkinoc, is there anything we can help with to get a release out with spring boot 3 support? Happy to get involved :)

@DarkAtra
Copy link
Contributor

Hey @akkinoc, could you please give a rough estimate on when we can expect this to be released?
I'm happy to get involved as well if there is anything i can help you with.

@akkinoc akkinoc changed the base branch from main to v4 April 23, 2023 04:07
@akkinoc akkinoc merged commit 04a15dc into akkinoc:v4 Apr 23, 2023
@akkinoc
Copy link
Owner

akkinoc commented Apr 23, 2023

Sorry for the late response.
Thank you for your contribution!

I created a v4 branch and merged your changes there.
I will continue working on the release (#336).

Please wait a little longer until the release.

@akkinoc
Copy link
Owner

akkinoc commented May 3, 2023

Thank you for waiting. I have released v4.0.0! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement An enhancement or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Spring Boot 3
4 participants