fix(fake-browser): Implement runtime.getURL

aklinker1 · Mar 2, 2023 · 270bd8f · 270bd8f
1 parent c8dba1c
commit 270bd8f
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 4 deletions.
diff --git a/packages/fake-browser/src/apis/runtime.test.ts b/packages/fake-browser/src/apis/runtime.test.ts
@@ -2,7 +2,7 @@ import { beforeEach, describe, expect, it, vi } from 'vitest';
 import { Runtime } from 'webextension-polyfill';
 import { fakeBrowser } from '..';
 
-describe('Fake Storage API', () => {
+describe('Fake Runtime API', () => {
  beforeEach(fakeBrowser.reset);
 
  describe('messaging', () => {
@@ -103,4 +103,18 @@ describe('Fake Storage API', () => {
  expect(listener).toBeCalledTimes(1);
  expect(listener).toBeCalledWith(input);
  });
+
+ describe('getURL', () => {
+ it('should return an extension URL', () => {
+ expect(fakeBrowser.runtime.getURL('options.html')).toBe(
+ `chrome-extension://test-extension-id/options.html`,
+ );
+ });
+
+ it('should return an extension URL, ignoring leading slashes', () => {
+ expect(fakeBrowser.runtime.getURL('/options.html')).toBe(
+ `chrome-extension://test-extension-id/options.html`,
+ );
+ });
+ });
 });
diff --git a/packages/fake-browser/src/apis/runtime.ts b/packages/fake-browser/src/apis/runtime.ts
@@ -1,4 +1,4 @@
-import { BrowserOverrides, FakeBrowser } from '../types';
+import { BrowserOverrides } from '../types';
 import { defineEventWithTrigger } from '../utils/defineEventWithTrigger';
 import { Runtime } from 'webextension-polyfill';
 
@@ -24,6 +24,9 @@ export const runtime: BrowserOverrides['runtime'] = {
  runtime.id = TEST_ID;
  },
  id: TEST_ID,
+ getURL(path: string) {
+ return `chrome-extension://${runtime.id}/${path.replace(/^\//, '')}`;
+ },
  onInstalled,
  onMessage,
  onStartup,

diff --git a/packages/fake-browser/src/types.ts b/packages/fake-browser/src/types.ts
@@ -40,9 +40,8 @@ export interface BrowserOverrides {
  onButtonClicked: EventForTesting<[notificationId: string, buttonIndex: number]>;
  onShown: EventForTesting<[notificationId: string]>;
  };
- runtime: {
+ runtime: Pick<Runtime.Static, 'id' | 'getURL'> & {
  resetState(): void;
- id: string;
  onSuspend: EventForTesting<[]>;
  onSuspendCanceled: EventForTesting<[]>;
  onStartup: EventForTesting<[]>;