Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps and add generated types #13

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

achingbrain
Copy link
Collaborator

Updates bl to pull in new buffer and also generates types from source
as the hand-written ones were incomplete.

Updates bl to pull in new buffer and also generates types from source
as the hand-written ones were incomplete.
@codecov
Copy link

codecov bot commented Apr 7, 2021

Codecov Report

Merging #13 (7fef365) into master (3e1e040) will decrease coverage by 0.69%.
The diff coverage is 96.29%.

❗ Current head 7fef365 differs from pull request most recent head d1f39e9. Consider uploading reports for the commit d1f39e9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
- Coverage   98.38%   97.69%   -0.70%     
==========================================
  Files           7        7              
  Lines         124      130       +6     
==========================================
+ Hits          122      127       +5     
- Misses          2        3       +1     
Impacted Files Coverage Δ
src/index.js 100.00% <ø> (ø)
src/int32BE-decode.js 100.00% <ø> (ø)
src/int32BE-encode.js 100.00% <ø> (ø)
src/varint-encode.js 100.00% <ø> (ø)
src/decode.js 95.65% <95.45%> (-1.23%) ⬇️
src/encode.js 100.00% <100.00%> (ø)
src/varint-decode.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e1e040...d1f39e9. Read the comment docs.

Copy link
Owner

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alanshaw alanshaw merged commit 3dc465b into alanshaw:master Apr 8, 2021
@achingbrain achingbrain deleted the chore/upgrade-deps-add-types branch April 8, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants