Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[local_bookmark:1.0] feat: Implement MVP #199

Conversation

MortalHappiness
Copy link

Albert Local Bookmark Plugin

Open the URLs defined in the local plain text file.

The format of the bookmark file

# Keyword 1
http://example1.com
# Keyword 2, Keyword 3
http://example2.com
# keyword 4
http://a.example3.com
http://b.example3.com
# Keyword 5
http://a.example4.com
# Keyword 5
http://b.example4.com

That is:

  • The keywords are preceded by a # and are comma-separated, and the URLs are listed below the keywords.
  • Empty lines are ignored.
  • The keyword and URL mappings can be 1 to 1, 1 to many, or many to 1.
  • URLs with the same keyword are allowed, as the "Keyword 5" shown in the example above.
  • Keywords are case-insensitive.

@ManuelSchneid3r
Copy link
Member

To be honest (while trying to be not offensive) the concept of this plugin and the quality of its implementation does not convice me. Some points:

  • The need. We have bookmark plugins (well unfortunately only chromium. thats a good point to start). Why though?
  • Python is a script language. This is a lot of code just to do the equivalent of having a dict the user could modify. Eg like
    d = {
    'http://my.url': ['s1', 's2', 's3'], 
    …
    }
  • The file is read and parsed and matched for every query
  • Does not use index tooling provided by the core. instead of using the power off C++ it pulls dependencies to achieve the same in python.

Even if the technical aspects would not apply I would rather not merge it because this is an absolute niche case. Hardly anybody will use it. So I dont think it makes sense to ship it upstream.

@ManuelSchneid3r
Copy link
Member

You can still put the project on awesome_albert. Where people can find and use it. Also there is some sort of python hub planned. If we have it I could easily ping you.

@MortalHappiness
Copy link
Author

@ManuelSchneid3r OK. Thanks for your recommendation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants