Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable facebook oauth in ui-demo #1041

Merged
merged 28 commits into from
Oct 10, 2024
Merged

feat: enable facebook oauth in ui-demo #1041

merged 28 commits into from
Oct 10, 2024

Conversation

linnall
Copy link
Collaborator

@linnall linnall commented Oct 10, 2024

Pull Request Checklist


PR-Codex overview

This PR focuses on enhancing the OAuth authentication experience by adding support for multiple providers and updating related components to handle the new configuration.

Detailed summary

  • Updated <ContinueWithOAuth /> to accept provider prop.
  • Changed oauthProvider type to KnownAuthProvider.
  • Modified OAuthConnectionFailed to use provider prop.
  • Introduced oAuthMethods configuration for Google, Facebook, and Auth0.
  • Updated Authentication component to manage OAuth states.
  • Refactored logic for handling OAuth methods in ConfigContextProvider.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

linnall and others added 27 commits October 9, 2024 03:34
Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:38am
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 1:38am

dphilipson
dphilipson previously approved these changes Oct 10, 2024
Copy link
Contributor

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! One nitpick.

examples/ui-demo/src/app/config.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@dphilipson dphilipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants