Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update demo video, scroll and dimensions on mobile #1043

Merged
merged 8 commits into from
Oct 10, 2024

Conversation

iykazrji
Copy link
Collaborator

@iykazrji iykazrji commented Oct 10, 2024

Pull Request Checklist

Screenshots

RPReplay_Final1728586503.MP4

PR-Codex overview

This PR focuses on enhancing the layout and styling of the TopNav, MobileSplashPage, and the main Home component in the application, improving responsiveness and visual consistency.

Detailed summary

  • Changed TopNav to use fixed positioning and adjusted background classes.
  • Updated Home component to use h-auto for dynamic height and added margin adjustments for child elements.
  • Modified MobileSplashPage to improve text sizes and layout, including a video element's dimensions.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 9:08pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2024 9:08pm

@iykazrji iykazrji changed the title feat: update scroll behaviour and splash page dimensions to fit actions above the fold feat: update demo video play behavior on mobile, scroll behaviour and splash page dimensions to fit actions above the fold Oct 10, 2024
@iykazrji iykazrji changed the title feat: update demo video play behavior on mobile, scroll behaviour and splash page dimensions to fit actions above the fold feat: update demo video play behavior on mobile, scroll behaviour and splash page dimensions Oct 10, 2024
@iykazrji iykazrji merged commit b816f05 into main Oct 10, 2024
6 checks passed
@iykazrji iykazrji deleted the iyk/fix-mobile-demo-video branch October 10, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants