Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: confest _http_session instead of http_session #150

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

1yam
Copy link
Collaborator

@1yam 1yam commented Aug 16, 2024

No description provided.

Copy link

Summary:
The change modifies the attribute name from http_session to _http_session within the AlephHttpClient class. This is a straightforward renaming of an attribute, which does not alter the functionality of the code or introduce any new features. The change is purely cosmetic and does not affect the behavior of the existing codebase.

Highlighting:

-    client.http_session = http_session
+    client._http_session = http_session

Explanation:
The modification involves a simple renaming of an attribute from http_session to _http_session. This change does not introduce any new functionality, nor does it affect the behavior of the code. It is a straightforward refactoring aimed at improving the readability or clarity of the codebase. As such, it falls under the 'BLUE' category, which typically includes changes that are unlikely to introduce bugs or require deep understanding of the project architecture.

@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Aug 16, 2024
@1yam 1yam requested a review from olethanh August 16, 2024 09:39
@hoh
Copy link
Member

hoh commented Aug 19, 2024

Can you explain what this fixes ?
Why is there a fixup! commit alone in a branch/PR ?

@1yam
Copy link
Collaborator Author

1yam commented Aug 19, 2024

We got this change:

d2f56b0

That i didn't see when merging the Price feature. So here the fix

@hoh hoh merged commit 04622be into main Aug 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLUE This PR is simple and straightforward.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants