Cosmos signature verification and fix #20
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cosmos code hasn't been updated since 2020. I added a test file for CSDK to check whether the signature verification function works correctly and found that the signing did not work at all.
I fixed it by making
CSDKAccount.public_key()
directly return a base64-encoded string, which is what is being stored inside the signature dictionary.Added the
verifiy_signature()
function as in Feature: Signature verification for Solana and Ethereum messages #19.Added
ecdsa
andcosmospy
to the testing requirements.