Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: Signatures generated with Python 3.11 are invalid #30

Merged
merged 1 commit into from
Jul 10, 2023

Conversation

hoh
Copy link
Member

@hoh hoh commented May 22, 2023

The signature buffer is affected by the new formatting of string
enums.

Solution: use the value of the message type enum.

Co-authored-by: Olivier Desenfans [email protected]

Copy link
Contributor

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current implementation of enum_as_str is incorrect. Also, maybe add tests for Python 3.11 in the CI?

src/aleph/sdk/utils.py Outdated Show resolved Hide resolved
@odesenfans
Copy link
Contributor

I think you need to rebase your PR.

src/aleph/sdk/utils.py Outdated Show resolved Hide resolved
odesenfans
odesenfans previously approved these changes Jul 10, 2023
The signature buffer is affected by the new formatting of string
enums.

Solution: use the value of the message type enum.

Co-authored-by: Olivier Desenfans <[email protected]>
@hoh hoh merged commit ee191ea into main Jul 10, 2023
10 checks passed
@hoh hoh deleted the hoh-fix-signatures branch July 10, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants