Feature : AlephDNS #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odesenfans
previously requested changes
Jul 13, 2023
aliel
force-pushed
the
1yam_domain
branch
2 times, most recently
from
ebb4afb
to
93ea8ad
Compare
|
Merge? Yes/No/Only with PBJ? |
hoh
reviewed
Aug 25, 2023
| async def query(self, name: str, query_type: str): | ||
| try: | ||
| return await self.resolver.query(name, query_type) | ||
| except Exception as e: |
There was a problem hiding this comment.
@aliel what is the exception that we are expected here ? Catching all exceptions to stdout is not a best practice.
| class AlephDNS: | ||
| def __init__(self): | ||
| self.resolver = aiodns.DNSResolver(servers=settings.DNS_RESOLVERS) | ||
| self.fqdn_matcher = re.compile(r"https?://?") |
| return None | ||
|
|
||
| def url_to_domain(self, url): | ||
| return self.fqdn_matcher.sub("", url).strip().strip("/") |
There was a problem hiding this comment.
You can simplify the strip() call
return self.fqdn_matcher.sub("", url).strip(" /")| def url_to_domain(self, url): | ||
| return self.fqdn_matcher.sub("", url).strip().strip("/") | ||
|
|
||
| async def get_ipv6_address(self, url: str): |
|
|
||
| async def check_domain_configured(self, domain, target, owner): | ||
| try: | ||
| print("Check...", target) |
There was a problem hiding this comment.
Why not use logging.debug instead of print here ?
| }, | ||
| "info": f"Create a CNAME record for {domain} with value {cname_value}", | ||
| "on_error": f"CNAME record not found: {domain}" | ||
| }) |
There was a problem hiding this comment.
Would it make sense to use a dataclasses instead of a dict for this data ?
|
|
||
| async def check_domain( | ||
| self, url: str, target: str, owner: Optional[str] = None | ||
| ): |
There was a problem hiding this comment.
Can you add a docstring to explain what this is checking ?
Comment on lines
+67
to
+74
| for _res in res: | ||
| if hasattr(_res, "text") and _res.text == record_value: | ||
| found = True | ||
|
|
||
| if found == False: | ||
| raise DomainConfigurationError( | ||
| (dns_rule["info"], dns_rule["on_error"], status) | ||
| ) |
There was a problem hiding this comment.
Why not use a for ... else ... loop ?
for _res in res:
if hasattr(_res, "text") and _res.text == record_value:
break
else:
raise DomainConfigurationError(
(dns_rule["info"], dns_rule["on_error"], status)
)
hoh
pushed a commit
that referenced
this pull request
Oct 23, 2023
* Feature : AlephDNS add instances support add ipfs support add program support --------- Co-authored-by: aliel <[email protected]>
aliel
added a commit
that referenced
this pull request
Nov 10, 2023
* Feature : AlephDNS add instances support add ipfs support add program support --------- Co-authored-by: aliel <[email protected]>
MHHukiewitz
added a commit
that referenced
this pull request
Nov 21, 2023
* Feature : AlephDNS (#47) * Feature : AlephDNS add instances support add ipfs support add program support --------- Co-authored-by: aliel <[email protected]> * Fix: Reformat with `black` * minor change on dns settings * avoid not valid local variable in certain conditions * add method to retreive txt values * fix dns record check * fix program cname value * Refactor: str -> Enum for DNS target * Refactor: Add types to arguments * Fix: variable did not exist * Add typing * Cleanup: imports with isort * Cleanup: typing * Refactor: domain_from_url * Refactor: use a generator * Cleanup: Add docstring and property * WIP: Refactor and cleanup domain related code * [dns] let checks continue * fix hostname_from_url when it's already a hostname * remove unused import * speedup dns detection using authoritative ns server * fix cname to target * fix cond * fix while loop * Fix typing; add docs; refactor for clarity --------- Co-authored-by: 1yam <[email protected]> Co-authored-by: aliel <[email protected]> Co-authored-by: mhh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement AlephDNS from @aliel inside SDK