Fixed the virtual machine hostname that causes the virtual machine to… #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should not crop the vm item_hash. If the source of this bug cannot be resolved, we should then use another representation of the item_hash such as it's base32 encoding. |
|
Tested with this code => |
hoh
force-pushed
the
aliel-fix-hostname-vm
branch
from
963a23f
to
3d489b9
Compare
hoh
force-pushed
the
aliel-fix-hostname-vm
branch
from
0d7385e
to
f9b09c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@todo after merge:
#123