Specialize vm_supervisor.vm for programs and instances #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Solution: Rename module `firecracker_microvm` into `firecracker_program`, in preparation to add new modules next to it.
Solution: Refactor in order to split generic methods shared by all firecracker virtual machines from program specific code. This makes it possible to implement other types of execution on top of Firecracker such as Instances. Co-authored-by: nesitor <[email protected]>
Solution: 1. Add support for running Instances with Firecracker. 2. Refactor all firecracker virtual machine code into a subpackage `vm_supervisor.vm.firecracker` to avoid namespace in filenames and in preparation for Qemu support. Co-authored-by: nesitor <[email protected]>
hoh
force-pushed
the
hoh-split-microvm-class
branch
from
8ab82da
to
00b15fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #323 with a different file structure and additional fixes.
This creates the following structure.
Program and Instance both inherit from Executable.
One commit should be squashed: WIP: Code from branch andres_split_microvm_class