Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: VM does not boot if no SSH key is specified #364

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

odesenfans
Copy link
Collaborator

Problem: The authorized_keys file could not be generated if the config.authorized_keys settings was None because it was used in a list comprehension.

Solution: check for None early.

@odesenfans odesenfans requested a review from hoh July 5, 2023 08:56
Problem: The authorized_keys file could not be generated if
the `config.authorized_keys` settings was None because it was
used in a list comprehension.

Solution: check for None early.
@odesenfans odesenfans force-pushed the od-fix-authorized-keys-none branch from d7b257d to 7a61b0d Compare July 5, 2023 20:39
@hoh
Copy link
Member

hoh commented Jul 5, 2023

Should we make the authorized keys a List with default [] instead of allowing None ?

@hoh hoh merged commit e0d83bc into main Jul 6, 2023
7 of 12 checks passed
@hoh hoh deleted the od-fix-authorized-keys-none branch July 6, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants