-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement VM snapshots #379
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le and share this data. Feature: Implement VM snapshots that will be managed independently.
odesenfans
requested changes
Jul 13, 2023
odesenfans
requested changes
Jul 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking clean, just a few more comments.
) Problem: the CI is looking for only one lock file, but apt/dpkg use several. Furthermore, `lslocks --json` seems to cut its output to a specific width, and configuration options (`--notruncate`) do not appear to have an impact. Solution: repeat calls to apt-get update until we get the lock. This is not perfect but increases the rate of success.
Updated creation script to create a BTRFS image of Ubuntu filesystem.
Added support for BTRFS to execute a VM instance.
odesenfans
approved these changes
Jul 14, 2023
hoh
added a commit
that referenced
this pull request
Mar 12, 2024
* Problem: Instances loose data between nodes, so we need a way to handle and share this data. Feature: Implement VM snapshots that will be managed independently. * Fix: Added some refactor for snapshots and handled some errors. * Fix: Split snapshot class in two. * Fix: Make it work well with threads and asyncio. * Fix: Added code improvements with threading and fixed PR comments. * Fix: Fixed check_disk method error. * Fix: Fixed more snapshot errors with multithreading * Fix: CI for Ubuntu was failing too often because of apt/dpkg locks (#380) Problem: the CI is looking for only one lock file, but apt/dpkg use several. Furthermore, `lslocks --json` seems to cut its output to a specific width, and configuration options (`--notruncate`) do not appear to have an impact. Solution: repeat calls to apt-get update until we get the lock. This is not perfect but increases the rate of success. * Create Ubuntu rootfs (#370) Updated creation script to create a BTRFS image of Ubuntu filesystem. * Fix: Use SDK version 0.7.0 (#371) * Support BTRFS filesystem for instances (#373) Added support for BTRFS to execute a VM instance. * Feature: Delete old snapshots after do a new one. * add dependency to python3-schedule * Fix latest_snapshot attribute error * default snapshot frequency 1 hour --------- Co-authored-by: Olivier Desenfans <[email protected]> Co-authored-by: Hugo Herter <[email protected]> Co-authored-by: Andres D. Molins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement VM snapshots that will be managed independently by a snapshot manager.