Fixes regarding concurrency #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cancelling the expiration must be done after the execution becomes ready. Solution: First wait for the execution to become ready before marking it as persistent and cancelling its expiration.
Problem: Checking the existence of the execution in one corouting and creating it in another could lead to an inconsistent state where two executions are starting for the same VM. Solution: Check for the existence of the execution or register it on the pool inside the same coroutine, without any `await` between
Problem: The method `prepare()` of a VM could be launched multiple times in parallel. Solution: Use a lock and skip the preparation if it has already been done.
hoh
force-pushed
the
hoh-fix-concurrency
branch
from
83ed4b6
to
580fcbf
Compare
olethanh
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds 3 fixes regarding the concurrency of launching the same VM multiple times
in a short period of time, before the setup of the other instances has finished.