Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CORS support on supervisor endpoints #542

Merged
merged 3 commits into from
Feb 20, 2024

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Feb 14, 2024

Fix: Implemented CORS support on supervisor endpoints.

@nesitor nesitor self-assigned this Feb 14, 2024
Copy link

Rationale:

  • The PR modifies multiple files in different directories. This indicates a large change that could potentially impact other parts of the codebase.
  • It adds new dependencies to pip3 install command which might introduce new bugs or unexpected behavior if not handled properly.
  • There are changes related to CORS configuration, which is a common practice for handling cross-origin requests in web applications but it's not clear how these changes will be used in the application.

This PR requires careful review and testing by experienced developers as it involves significant changes that could potentially impact other parts of the codebase or introduce new bugs if not handled properly. The CORS configuration changes are also worth noting, which might require further investigation to understand their implications on the overall system architecture.

Please note that this is a general assessment based on the provided information and may need additional context for a more accurate categorization.

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Feb 14, 2024
@hoh
Copy link
Member

hoh commented Feb 14, 2024

Thanks !

Can we use the version of aiohttp-cors shipped in Debian ?
https://packages.debian.org/bullseye/python3-aiohttp-cors

Should we remove the duplication with a custom decorator that wraps custom_cors(...) ?

@nesitor nesitor merged commit efb5b30 into main Feb 20, 2024
18 checks passed
@nesitor nesitor deleted the andres-fix-add_cors_support_endpoints branch February 20, 2024 14:05
hoh pushed a commit that referenced this pull request Mar 12, 2024
* Fix: Implemented CORS support on supervisor endpoints.

* Fix: Apply code review suggestions.

* Fix: Apply same new decorator to operator endpoints.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants