Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CI did not run pytest #545

Merged
merged 6 commits into from
Mar 4, 2024
Merged

Fix: CI did not run pytest #545

merged 6 commits into from
Mar 4, 2024

Conversation

hoh
Copy link
Member

@hoh hoh commented Feb 20, 2024

We have integration tests, and some unit tests using pytest but the CI does not run them.

Our CI should run hatch run testing:test and ensure that it succeeds.

This requires fixing bugs in the unit tests, the pipeline itself.

Do not squash.

@hoh hoh marked this pull request as ready for review February 22, 2024 12:02
@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Feb 22, 2024
@aleph-im aleph-im deleted a comment from github-actions bot Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@83b4f9b). Click here to learn what that means.

Files Patch % Lines
tests/supervisor/test_jwk.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #545   +/-   ##
=======================================
  Coverage        ?   34.74%           
=======================================
  Files           ?       52           
  Lines           ?     4737           
  Branches        ?      553           
=======================================
  Hits            ?     1646           
  Misses          ?     3073           
  Partials        ?       18           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Solution: Add pytest-cov and update related test dependencies
Copy link
Member

@MHHukiewitz MHHukiewitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit 2401133 into main Mar 4, 2024
20 checks passed
@MHHukiewitz MHHukiewitz deleted the hoh-fix-pytest branch March 4, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLACK This PR has critical implications and must be reviewed by a senior engineer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants