Fix: Failing to restart nddpd caused the exception to escalate
#584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ndppd` service is not always required and restarting it can fail. While waiting for a better fix that prevents restarting the service too quickly, this logs an error instead of raising an exception.
nesitor
approved these changes
Mar 20, 2024
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 35.19% 35.18% -0.01%
==========================================
Files 53 53
Lines 4870 4874 +4
Branches 579 579
==========================================
+ Hits 1714 1715 +1
- Misses 3135 3138 +3
Partials 21 21 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ndppdservice is not always required and restarting it can fail.While waiting for a better fix that prevents restarting the service too quickly, this logs an error instead of raising an exception.