Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Pytest did not test legacy diagnostic #603

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Fix: Pytest did not test legacy diagnostic #603

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions tests/supervisor/test_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,13 @@ async def test_create_execution():


@pytest.mark.asyncio
async def test_create_execution_online():
async def test_create_execution_online(vm_hash: ItemHash = None):
"""
Create a new VM execution without building it locally and check that it starts properly.
"""

vm_hash = vm_hash or settings.CHECK_FASTAPI_VM_ID

# Ensure that the settings are correct and required files present.
settings.setup()
settings.check()
Expand All @@ -71,7 +73,6 @@ async def test_create_execution_online():
engine = metrics.setup_engine()
await metrics.create_tables(engine)

vm_hash = ItemHash("3fc0aa9569da840c43e7bd2033c3c580abb46b007527d6d20f2d4e98e867f7af")
message = await get_message(ref=vm_hash)

execution = VmExecution(
Expand All @@ -93,3 +94,11 @@ async def test_create_execution_online():

await execution.start()
await execution.stop()


@pytest.mark.asyncio
async def test_create_execution_legacy():
"""
Create a new VM execution based on the legacy FastAPI check and ensure that it starts properly.
"""
await test_create_execution_online(vm_hash=settings.LEGACY_CHECK_FASTAPI_VM_ID)
Loading