Fix: Unkwnown hashes raised exception #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoh
force-pushed
the
hoh-dont-raise-unknown-hash
branch
from
1590ee3
to
d0dcd0c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
+ Coverage 44.82% 45.17% +0.34%
==========================================
Files 55 56 +1
Lines 5033 5063 +30
Branches 589 593 +4
==========================================
+ Hits 2256 2287 +31
+ Misses 2654 2653 -1
Partials 123 123 ☔ View full report in Codecov by Sentry. |
hoh
force-pushed
the
hoh-dont-raise-unknown-hash
branch
from
d0dcd0c
to
031816c
Compare
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
nesitor
approved these changes
May 3, 2024
nesitor
reviewed
May 3, 2024
Problem: Many crawlers called URLs that do not exist on CRNs. The current implementation raises an error when the hash of the VM cannot be found, which fills the logs on Sentry. Solution: Return an HTTP Not Found status instead.
hoh
force-pushed
the
hoh-dont-raise-unknown-hash
branch
from
031816c
to
a6af70b
Compare
|
Hi @nesitor , I added tests and requested a new review ;-) |
nesitor
reviewed
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Many crawlers called URLs that do not exist on CRNs.
The current implementation raises an error when the hash of the VM cannot be found, which fills the logs on Sentry.
Solution: Return an HTTP Not Found status instead.