Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Backquote in shell script executed command #611

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

hoh
Copy link
Member

@hoh hoh commented May 2, 2024

When executed using bash, the create_disk_image was interrupted by a Python REPL due to the python -OO command being surrounded by backquotes.

When executed using `bash`, the `create_disk_image` was interrupted by a Python REPL due to the `python -OO` command being surrounded by backquotes.
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.87%. Comparing base (c7db4ef) to head (d0920a6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #611   +/-   ##
=======================================
  Coverage   43.87%   43.87%           
=======================================
  Files          55       55           
  Lines        4978     4978           
  Branches      587      587           
=======================================
  Hits         2184     2184           
  Misses       2677     2677           
  Partials      117      117           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 2, 2024

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

@hoh hoh requested a review from olethanh May 3, 2024 09:35
@olethanh
Copy link
Collaborator

olethanh commented May 3, 2024

@hoh is it like a fish or dash only error? Because I don't have the issue with Debian's bash

@olethanh olethanh merged commit ffa2322 into main May 3, 2024
24 checks passed
@Psycojoker Psycojoker deleted the hoh-fix-backquotes branch July 24, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants