-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: System testing on DO took too many resources #614
Conversation
Problem: Running system testing on DigitalOcean for every push consumed a lot of resources and failed frequently. We now start to have integration testing using `pytest`, which provides a better confidence that things actually work. Solution: Only test on DO open Pull Requests and not every push. In the future, consider only running when merged on `main`.
The PR is focusing on updating a GitHub Actions workflow file. This change is small and simple, likely due to a change in the rules for the workflow, or updating the workflow to a new version. The diff shows that the workflow is being updated and not removed or renamed, which is a common practice in GitHub Actions. The workflow is still being run and tested, which is good. The changes do not seem to affect the core functionality of the system, or the overall architecture of the codebase, so the risk of introducing bugs is low. The impact on the codebase and review process is also minimal. diff --git a/.github/workflows/test-on-droplets-matrix.yml b/.github/workflows/test-on-droplets-matrix.yml
index c67c1688..84746938 100644
--- a/.github/workflows/test-on-droplets-matrix.yml
+++ b/.github/workflows/test-on-droplets-matrix.yml
@@ -1,107 +1,30 @@
-name: "Test on DigitalOcean Droplets"
-
+# These are end-to-end tests running on ephemeral DigitalOcean "Droplet" virtual machines
+# with the different operating systems that are supported.
+#
+# The main focus of these tests is to ensure that the packaging works on all supported platforms
+# and to ensure the compatibility of dependencies (system and vendored) across these platforms.
+name: "Testing on DigitalOcean Droplets"
+
+# Run automatically on main branches, Pull Request updates and allow manual execution using `workflow_dispatch`.
on:
- push
+ push:
+ branches:
+ - main
+ pull_request:
+ types:
+ -
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 43.87% 43.87%
=======================================
Files 55 55
Lines 4978 4978
Branches 587 587
=======================================
Hits 2184 2184
Misses 2677 2677
Partials 117 117 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, simple restructuring
Problem: Running system testing on DigitalOcean for every push consumed a lot of resources and failed frequently.
We now start to have integration testing using
pytest
, which provides a better confidence that things actually work.Solution: Only test on DO open Pull Requests and not every push. In the future, consider only running when merged on
main
.