601 creating instance tests #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding a test that start and stop a simple fake instance
Creating an instance locally using fake_data and checks if the execution start and stop properly. Doing the same checks with the VM created.
Closed
1 task
Black check was failing Solution: Use black to format bad files
isort check was failing Solution: Use isort to format bad files
* Feature: Added automatic tests to check if QEmu runs. * Fix: Added code quality fixes. * Fix: Changed runtime generation script name. * Fix: Solve conflicts with main branch.
ruff check was failing Solution: Use ruff to format bad files
This deploys the main branch automatically on the staging servers for system testing.
Problem: Many crawlers called URLs that do not exist on CRNs. The current implementation raises an error when the hash of the VM cannot be found, which fills the logs on Sentry. Solution: Return an HTTP Not Found status instead.
mypy was failing because I tried to stop an execution but did not checked if there was an existing execution Solution: Check first if there an execution and then stop and shutdown
Adding a test that start and stop a simple fake instance
Creating an instance locally using fake_data and checks if the execution start and stop properly. Doing the same checks with the VM created.
Black check was failing Solution: Use black to format bad files
isort check was failing Solution: Use isort to format bad files
ruff check was failing Solution: Use ruff to format bad files
mypy was failing because I tried to stop an execution but did not checked if there was an existing execution Solution: Check first if there an execution and then stop and shutdown
…ph-vm into 601-creating-instance-tests
Instance test try to chmod a user named jailman that did not exist Solution: Creating the user jailman
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
===========================================
+ Coverage 44.82% 56.15% +11.32%
===========================================
Files 55 59 +4
Lines 5033 5250 +217
Branches 589 597 +8
===========================================
+ Hits 2256 2948 +692
+ Misses 2654 2172 -482
- Partials 123 130 +7 ☔ View full report in Codecov by Sentry. |
nesitor
reviewed
May 17, 2024
This job to create a new user do not need hes own job, we could just insert it in a previous job
nesitor
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Added tests to check if Firecracker instance runs with network interface.
The tests bypass systemd manager