Fix: Orchestrator failed with assert result["result"] == HTTPOk.status_code
#628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #628 +/- ##
==========================================
+ Coverage 58.32% 58.70% +0.37%
==========================================
Files 61 62 +1
Lines 5464 5485 +21
Branches 607 609 +2
==========================================
+ Hits 3187 3220 +33
+ Misses 2137 2125 -12
Partials 140 140 ☔ View full report in Codecov by Sentry. |
nesitor
reviewed
Jun 5, 2024
olethanh
reviewed
Jun 12, 2024
hoh
force-pushed
the
hoh-fix-internet-check
branch
from
f242be6
to
0e656ba
Compare
…us_code`
Problem:
The diagnostic VM returned HTTP 200 with {"result": False} when it could not connect to the internet.
Since this is an OK return code, `raise_for_status` did not raise an error and an assertion error was raised.
Solution:
Test that the returned status code also corresponds to HTTP OK.
hoh
force-pushed
the
hoh-fix-internet-check
branch
from
0e656ba
to
d6abcad
Compare
nesitor
approved these changes
Jun 12, 2024
olethanh
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The diagnostic VM returned HTTP 200 with {"result": False} when it could not connect to the internet.
Since this is an OK return code,
raise_for_statusdid not raise an error and an assertion error was raised.Solution:
Test that the returned status code also corresponds to HTTP OK.
Stacktrace: