Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve instances code #654

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Improve instances code #654

merged 1 commit into from
Jul 5, 2024

Conversation

nesitor
Copy link
Member

@nesitor nesitor commented Jul 4, 2024

Problem: If an instance is created and removed, one of the base mounted devices remains on the system. Also, a user cannot create a Qemu disk from Debian image.

Solution: Remove the useless device from the system and create the two needed script to create Qemu Debian runtimes.

…ed devices remains on the system. Also, a user cannot create a qemu disk from Debian image.

Solution: Remove the useless device from the system and create the two needed script to create Qemu Debian runtimes.
@nesitor nesitor self-assigned this Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.97%. Comparing base (45c14c5) to head (08eb1f4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
+ Coverage   59.94%   59.97%   +0.02%     
==========================================
  Files          64       64              
  Lines        5458     5459       +1     
  Branches      592      592              
==========================================
+ Hits         3272     3274       +2     
- Misses       2043     2044       +1     
+ Partials      143      141       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@olethanh olethanh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nesitor nesitor merged commit 1fedcd7 into main Jul 5, 2024
24 checks passed
@nesitor nesitor deleted the andres-fix-improve_instances branch July 5, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants