Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI slowness and correct execution tests #686

Merged
merged 8 commits into from
Sep 2, 2024
Merged

Fix CI slowness and correct execution tests #686

merged 8 commits into from
Sep 2, 2024

Commits on Aug 29, 2024

  1. Problem: Execution tests were very slow 

    Solution: This was due to an import in the test app that is somehow
very slow but only during testing.

Haven't figured out why it is slow, but have implemented a workaround
that delay the import so it's not hit during the tests
    @olethanh
    olethanh committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    dfed463 View commit details
    Browse the repository at this point in the history

  2. Fix 'real' executions test were testing the fake VM 

    This was due to as settings contamination which made it runn the FAKE_DATA_PROGRAM instead of the real one

Also correct some things that made the test not run (load_update_mesage
instead of get_message)
    @olethanh
    olethanh committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    98d18df View commit details
    Browse the repository at this point in the history

  3. Correct the Workflow name 

    It was the same name as an other workflow which caused issue in github
    @olethanh
    olethanh committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    1e57721 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2024

  1. Execution test were failing on Python 3.12 

    Due to change in behaviour of unix_socket.wait_closed
    @olethanh
    olethanh committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    3ee65ab View commit details
    Browse the repository at this point in the history

  2. Symlink don't work so make a copy instead

    @olethanh
    olethanh committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    f959243 View commit details
    Browse the repository at this point in the history

  3. add vm-connector in test runner

    @olethanh
    olethanh committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    06b5538 View commit details
    Browse the repository at this point in the history

  4. Increase timeout for ci

    @olethanh
    olethanh committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    c9acb74 View commit details
    Browse the repository at this point in the history

  5. Update comment src/aleph/vm/hypervisors/firecracker/microvm.py 

    Co-authored-by: Hugo Herter <[email protected]>
    @olethanh @hoh
    olethanh and hoh committed Sep 2, 2024
    Configuration menu
    Copy the full SHA
    15214f4 View commit details
    Browse the repository at this point in the history