Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter and sort objects (messages, posts, etc) by confirmation block ID #445 #446

Merged
merged 2 commits into from
Dec 12, 2023
Merged

Filter and sort objects (messages, posts, etc) by confirmation block ID #445 #446

merged 2 commits into from
Dec 12, 2023

Conversation

MHHukiewitz
Copy link
Member

See #445

odesenfans
odesenfans previously requested changes May 31, 2023
View reviewed changes
Copy link
Contributor

@odesenfans odesenfans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor fixes.

src/aleph/db/accessors/messages.py Show resolved Hide resolved
src/aleph/db/accessors/messages.py Outdated Show resolved Hide resolved
@MHHukiewitz MHHukiewitz marked this pull request as ready for review June 6, 2023 13:51
@MHHukiewitz MHHukiewitz force-pushed the mhh-filter-confirmation-block branch from 19e1042 to 5945543 Compare August 5, 2023 12:37
@aliel aliel requested review from hoh and removed request for odesenfans December 12, 2023 08:35
@hoh
Copy link
Member

hoh commented Dec 12, 2023

Can you make sure to target the dev and not master branch ?

@MHHukiewitz MHHukiewitz changed the base branch from master to dev December 12, 2023 14:34
@MHHukiewitz MHHukiewitz dismissed odesenfans’s stale review December 12, 2023 14:34

Suggestions applied, reviewer not responsible anymore

@MHHukiewitz MHHukiewitz merged commit 7874553 into dev Dec 12, 2023
4 checks passed
@MHHukiewitz MHHukiewitz deleted the mhh-filter-confirmation-block branch December 12, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@odesenfans odesenfans odesenfans left review comments

@aliel aliel aliel approved these changes

@hoh hoh Awaiting requested review from hoh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MHHukiewitz @hoh @aliel @odesenfans