Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kiosk mode is broken #513

Open
satterly opened this issue Jan 1, 2022 · 1 comment
Open

Kiosk mode is broken #513

satterly opened this issue Jan 1, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@satterly
Copy link
Member

satterly commented Jan 1, 2022

"kiosk" url parameter is passed to API calls
API knows nothing about it (I guess it actually shouldn't) and returns error

I think we should remove this parameter from API call or maybe change the way kiosk mode is enabled?

Originally posted by @sp1r in #55 (comment)

@satterly
Copy link
Member Author

satterly commented Jan 1, 2022

This patch works for me:

--- a/src/store/modules/alerts.store.ts
+++ b/src/store/modules/alerts.store.ts
@@ -160,6 +160,7 @@ const actions = {
         moment().utc().add(state.filter.dateRange[1], 'seconds').toISOString() // seconds offset
       )
     }
+    params.delete('kiosk')
 
     return AlertsApi.getAlerts(params)
       .then(({ alerts, total, pageSize }) => commit('SET_ALERTS', [alerts, total, pageSize]))
@@ -263,6 +264,7 @@ const actions = {
         moment().utc().add(state.filter.dateRange[1], 'seconds').toISOString() // seconds offset
       )
     }
+    params.delete('kiosk')
 
     return AlertsApi.getEnvironments(params)
       .then(({ environments }) => commit('SET_ENVIRONMENTS', environments))
-- 

Originally posted by @sp1r in #55 (comment)

@satterly satterly added the bug Something isn't working label Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant