Implement fixes from some repos that aren't being tracked yet #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This had been copy-pasted from the kotlin grammar but the two aren't actually the same. Swift allows shorter escape sequences but requires them to be enclosed in braces. Fixes #42
The grammar hardcodes a few directive-looking things that we don't handle today, namely playground literals and key path strings. Adding those in explicitly for now, but this is worth reevaluating in the future; it may be better to go generic and let the real language be more restrictive. Fixes #43
Intentionally not encoding the requirement that dynamic must always be accompanied by @objc, because there isn't really a reason to.
Luckily, these are already pretty loosely defined so that the block is optional, so we can still just have a single definition in the grammar for both.
alex-pinkus
force-pushed
the
fixes-from-not-yet-tracked-repos
branch
from
98900c2
to
9402a4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to add a big new repository into top-repos, but we're failing
a bit more than I'd like (and there's some optimization work to do).
Still, there's no reason not to land the fixes while improvements
continue.