Support attributes in a few places where they should be legal #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
alex-pinkus
commented
Dec 31, 2021
alex-pinkus
commented
- Support attributes within lambda literals
- Support annotated inheritance specifiers
It's not clear how exactly these are legal, since they aren't called out in the grammar. However, GRDB uses them in code that ostensibly compiles. The grammar assumes that the attributes apply directly to a capture list (and can only exist if the capture list does). This has the same ambiguity that attributes in computed properties do, since it comes before a block of statements (which might be local declarations).
Clearly these were intended to be supported at one point but I never hooked them up. There's already an `_annotated_inheritance_specifier` rules, but it's just unused.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.